Fix ceph 9 RGW deployment #3436
Conversation
|
Early testing looks promising: |
fmount
force-pushed
the
ceph9
branch
3 times, most recently
from
78a7e21 to
2e51e5f
Compare
|
@fmount should it be DNM (PR has such label)? |
If the current / in progress |
|
both unigamma (which deploys ceph 7) and unidelta (where we have ceph 8 and we're going to move to 9) are working properly with this patch. By default we keep backward compatibility, so no changes are required for the existing jobs, while for unidelta we're going to have a |
|
rebased. |
|
/lgtm |
|
Note from myself: we need to cherry-pick this patch to FR4 as a prereq for the transition to Ceph 9. |
rgw_frontend_ssl_certificate has been deprecated in ceph8 and in ceph9 doesn't work properly anymore. There's a new way of setting both cert and key when ssl is used and is fully documented in [1]. This patch still preserves the old way of deploying rgw through a new var used to execute the old code. When "rgw_ssl_backward_compatibility" is set, the old facts are set, resulting in populating the old variables, otherwise the new method based on ssl_cert and ssl_key is applied. [1] https://docs.ceph.com/en/latest/cephadm/services/rgw/ Signed-off-by: Francesco Pantano <[email protected]>
|
Ah the charming little differences that keep life interesting.... "deprecated in ceph8 and in ceph9 doesn't work properly anymore. There's a new way of setting both cert and key when ssl is used and is fully documented in [1]." |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fultonj The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
tosky
left a comment
tosky
left a comment
There was a problem hiding this comment.
The change makes sense and the default behavior is unchanged.
|
/cherry-pick 18.0-fr4 |
|
@fmount: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
rgw_frontend_ssl_certificatehas been deprecated inceph8and inceph9doesn't work properly anymore. There's a new way of setting both cert and key whensslis used and is fully documented in [1].This patch preserves the old way of deploying
rgwthrough a new var used to execute the old code. Whenrgw_ssl_backward_compatibilityis set, the old facts are created, resulting in populating the old variables, otherwise the new method based onssl_certandssl_keyfields is applied.[1] https://docs.ceph.com/en/latest/cephadm/services/rgw/
Jira: https://issues.redhat.com/browse/OSPRH-21250